Add a description to the files property of the Environment helper component. #2114
+1
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I am requesting this change because I am new to fiber and Drei. I was looking at the docs and as someone coming from vanilla three.js to fiber I would get under the assumption that to load one single file I would use the path property, and to load cube map textures I'd use the files property which isn't the case. If you think my description isn't well enough you don't have to use it. But please clarify how the 2 properties are used.
|
@itsmahmoud-dev is attempting to deploy a commit to the Poimandres Team on Vercel. A member of the Team first needs to authorize it. |
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I am requesting this change because I am new to fiber and Drei. I was looking at the docs and as someone coming from vanilla three.js to fiber I would get under the assumption that to load one single file I would use the path property, and to load cube map textures I'd use the files property which isn't the case. If you think my description isn't well enough you don't have to use it. But please clarify how the 2 properties are used.
Why
edit to the documentation of the files property of the environment helper component.
just edit the docs to make it clearer for someone new