Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add annotations for tree shaking #2199

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

CodyJasonBennett
Copy link
Member

Why

Implements #1158.

What

Adds pure annotations to tree-shake top-level expressions. This can be done at build-time with an AST such as from Babel. Need to verify whether built-ins like Symbol#for and Set/WeakMap constructors are picked up as pure. Same with mutations in Rafz.

Checklist

  • Documentation updated
  • Demo added
  • Ready to be merged

@changeset-bot
Copy link

changeset-bot bot commented Sep 16, 2023

⚠️ No Changeset found

Latest commit: 2f43f09

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel
Copy link

vercel bot commented Sep 16, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
react-spring ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 16, 2023 0:04am

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant