Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Turn Expr.append into DSL Expr::Append #19536

Open
wants to merge 9 commits into
base: main
Choose a base branch
from

Conversation

coastalwhite
Copy link
Collaborator

Fixes #1535.

@github-actions github-actions bot added internal An internal refactor or improvement python Related to Python Polars rust Related to Rust Polars labels Oct 30, 2024
@coastalwhite coastalwhite changed the title refactor: Turn Expr.append into Expr::Append refactor: Turn Expr.append into DSL Expr::Append Oct 30, 2024
@ritchie46
Copy link
Member

We should use the existing Expr::Function for this, then we don't have to implement the whole physical expressions. I don't think this operation is worth a dedicated core node.

Copy link

codecov bot commented Nov 4, 2024

Codecov Report

Attention: Patch coverage is 96.59091% with 3 lines in your changes missing coverage. Please review.

Project coverage is 79.37%. Comparing base (e52a598) to head (5f0a36a).
Report is 102 commits behind head on main.

Files with missing lines Patch % Lines
...ars-plan/src/plans/conversion/type_coercion/mod.rs 96.55% 2 Missing ⚠️
crates/polars-plan/src/dsl/function_expr/mod.rs 66.66% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #19536      +/-   ##
==========================================
- Coverage   79.91%   79.37%   -0.54%     
==========================================
  Files        1536     1550      +14     
  Lines      211659   214796    +3137     
  Branches     2445     2460      +15     
==========================================
+ Hits       169156   170504    +1348     
- Misses      41948    43733    +1785     
- Partials      555      559       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@coastalwhite
Copy link
Collaborator Author

We should use the existing Expr::Function for this, then we don't have to implement the whole physical expressions. I don't think this operation is worth a dedicated core node.

Done now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
internal An internal refactor or improvement python Related to Python Polars rust Related to Rust Polars
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Completely remove map_binary
3 participants