docs: Add example and tests for pl.concat() with Expr input
#19836
+38
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
documentation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #19836 +/- ##
=======================================
Coverage 79.33% 79.33%
=======================================
Files 1548 1548
Lines 214245 214245
Branches 2460 2460
=======================================
+ Hits 169968 169974 +6
+ Misses 43719 43713 -6
Partials 558 558 ☔ View full report in Codecov by Sentry. |
eitsupi
reviewed
Nov 17, 2024
py-polars/polars/functions/eager.py
Outdated
| how : {'vertical', 'vertical_relaxed', 'diagonal', 'diagonal_relaxed', 'horizontal', 'align'} | ||
| Series only support the `vertical` strategy. | ||
| This is not used when items are Expr. Series only support the `vertical` strategy. |
There was a problem hiding this comment.
I think vertical should be checked for Expr as well.
There was a problem hiding this comment.
Suggested change
| This is not used when items are Expr. Series only support the `vertical` strategy. | |
| Series and Expr only support the `vertical` strategy. |
|
Test failures only appear with the new streaming engine but I have no idea why. Should I remove the new test? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #19813