Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Switch back to PyO3 0.22 #19851

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

itamarst
Copy link
Contributor

@itamarst itamarst commented Nov 18, 2024

Now that much more of the Python API releases the GIL, the chance of deadlocks is lower and it seems worth upgrading to 0.22 again (especially since 0.23 was just released, and that is going to be its own whole thing...).

This reverts commit e1dfcdd.

@github-actions github-actions bot added internal An internal refactor or improvement python Related to Python Polars rust Related to Rust Polars labels Nov 18, 2024
@itamarst itamarst marked this pull request as ready for review November 18, 2024 14:46
Copy link

codecov bot commented Nov 18, 2024

Codecov Report

Attention: Patch coverage is 70.58824% with 5 lines in your changes missing coverage. Please review.

Please upload report for BASE (main@f893f75). Learn more about missing BASE report.

Files with missing lines Patch % Lines
crates/polars-python/src/file.rs 0.00% 5 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main   #19851   +/-   ##
=======================================
  Coverage        ?   79.40%           
=======================================
  Files           ?     1550           
  Lines           ?   214919           
  Branches        ?     2447           
=======================================
  Hits            ?   170661           
  Misses          ?    43701           
  Partials        ?      557           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
internal An internal refactor or improvement python Related to Python Polars rust Related to Rust Polars
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants