Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changes for Jekyll 3.x #145

Closed
wants to merge 10 commits into from
Closed

Conversation

JuanjoSalvador
Copy link

No more warnings on email when I update my web.

This fix #144

Juan José Salvador added 3 commits March 5, 2016 20:43
Removed permalinks, change MD engine to kramdown and highlighter to rouge.
@pauldotknopf
Copy link

MERGE THIS IN!

@karlhorky
Copy link

@mdo does this look ok? Can it be merged?

@JuanjoSalvador
Copy link
Author

Hey @karlhorky, I'm using this changes for my web since I pulled this and everthing is OK :)

@karlhorky
Copy link

karlhorky commented Jun 28, 2016

Yep, it's working for me too, as long as I add the two jekyll gem dependencies to the config file.

gems: [jekyll-paginate, jekyll-gist]

But I think fixing the dependencies can be done with a separate pull request, since it doesn't strictly concern Jekyll 3.

Hm, maybe that's not entirely accurate that Jekyll 3 didn't cause this issue with the dependencies. It says on the pagination docs page:

For Jekyll 3, include the jekyll-paginate plugin in your Gemfile

In any case, would be good to get a response from one of the maintainers like @mdo so that some (or both) of these changes can be merged.

Juan José Salvador and others added 7 commits July 27, 2016 00:26
It needs `jekyll-paginate` gem as dependecy to work.
…indows and Linux. File verified with yamllint.com
Fixed _config.yml gems line indentation
removes spacing issue with _config.yml and removes gist tag unrecogni…
@mdo
Copy link
Member

mdo commented Apr 4, 2020

Fix coming in #258.

@mdo mdo closed this Apr 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Changes for Jekyll 3.x
7 participants