Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change baseurl from '/' to '' as per Jekyll norm #93

Closed
wants to merge 2 commits into from

Conversation

jonbartlett
Copy link

I have been trying to use Jekyll Sitemap against my Hyde based site and have faced issues with this line of code in _config.yml:

baseurl: /

The problem is that Jekyll Sitemap creates sitemap.xml file with incorrect urls (note the double //):

<url>
<loc>
http://www.jonbartlett.org//notes/dave-yates-frame-building/
</loc>
<lastmod>2014-09-30T00:00:00+00:00</lastmod>
</url>
<url>
<loc>http://www.jonbartlett.org//404.html</loc>

Looking around at other Jekyll sites the baseurl is set to '' in most cases. The Lanyon theme is configured like this.

Also when running jekyll serve this fires up on Server address: http://127.0.0.1:4000//. Note the trailing slash.

Pull request addresses these issues by modifying _config.yml and updating files that reference baseurl.

@jonbartlett jonbartlett changed the title changes to reflect removal of baseurl being '/' Change baseurl from '/' to '' as per Jekyll norm May 22, 2015
@defeo
Copy link

defeo commented May 22, 2015

👍

@nickserv
Copy link

👍

@jessdarneswrites
Copy link

Any update on this? I've noticed this as well in my sitemap.xml file after forking hyde.

jessdarneswrites pushed a commit to jessdarneswrites/jessdarneswrites.github.io that referenced this pull request Jul 16, 2015
johnowl added a commit to johnowl/johnowl.github.io that referenced this pull request Feb 3, 2017
joanasouza pushed a commit to joanasouza/joanasouza.github.io that referenced this pull request Jan 8, 2018
Enable pinch zooming on mobile devices
@mdo
Copy link
Member

mdo commented Apr 4, 2020

Fix coming in #258.

@mdo mdo closed this Apr 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants