Handle unsupported R versions; prefer current "current" version of R #2652

jennybc · 2024-04-04T15:43:05Z

Addresses #2440, addresses #2535. Also related to #2316 and #2659.

QA notes

Main goal: stop offering to launch unsupported versions of R

Install an unsupported version of R, presumably alongside at least 1 supported version. I would personally use rig for this. Unsupported is anything prior to 4.2. rig add 4.1.3 would do the trick. rig available can be handy.
Launch Positron.
The unsupported version of R should not appear in the interpreter dropdown.
The Positron R Extension output channel should show us discovering the unsupported version of R, but ultimately filtering it out because the version < 4.2.

Secondary goal: Keep launching the current version of R even if that changes

Open Positron in an R-flavored workspace. Make sure the automatically launched R version is indeed the current default on your system. Quit Positron. The point of this is to guarantee that the stored metadata includes current: true.
Change your default version of R. For example, use rig add devel then rig default devel. rig list is useful for checking things.
Relaunch Positron. Presumably it opens the same workspace as in step 1. It should, however, fire up R devel this time, because that is the current "current" version of R.

Secondary goal: Still possible to use non-current version of R

Continuing from above ...

Use the interpreter dropdown to select R release (4.3.3 today), which is not currently the default. This is how you say "no, I really do want 4.3.3 in this workspace, even if it is not the current version of R".
Quit Positron. The point of this is to guarantee that the stored metadata includes current: false.
Relaunch Positron. Presumably it opens in the same workspace as before. It should fire up R release, because the stored metadata had current: false so the bin path should be taken literally.

jennybc · 2024-04-04T22:55:52Z

extensions/positron-r/src/constants.ts

@@ -6,3 +6,6 @@ import * as path from 'path';

 // The extension root directory.
 export const EXTENSION_ROOT_DIR = path.join(__dirname, '..');
+
+// The minimum supported version of R
+export const MINIMUM_R_VERSION = '4.2.0';


I don't want this to be some Magic Number inlined in provider.ts, r-installation.ts, and the like. Is there an even more central place to put this? I could imagine it being useful outside of the positron-r code.

You could put it in the package.json file, which is readily readable in ts files via require and could also be consumed easily from outside them.

OK I did that. It looks like we already have positron for custom data, so I added there. Are you OK with the mechanics of how I did this?

jennybc · 2024-04-04T22:57:21Z

extensions/positron-r/src/provider.ts

+	// TODO: possible location to tell the user why certain R installations are being omitted from
+	// the interpreter drop-down and, in some cases, offer to help fix the situation:
+	// * version < minimum R version supported by positron-r
+	// * (macOS only) version is not orthogonal and is not the current version of R
+	// * invalid R installation


This enhanced experience is covered by #1397. For now, the UX, such as it is, is logging rejected R installations in the output channel.

extensions/positron-r/src/runtime-manager.ts

jennybc · 2024-04-04T23:01:30Z

extensions/positron-r/src/runtime-manager.ts

+		let inst: RInstallation;
+		if (curBin && metadataExtra.current) {
+			// If the metadata says that it represents the "current" version of R, interpret that to
+			// mean the current "current" version of R, at this very moment, not whatever it was
+			// when this metadata was stored.
+			// The motivation for this mindset is immediate launch of an affiliated runtime.
+			// More thoughts in this issue:
+			// https://github.com/posit-dev/positron/issues/2659
+			inst = new RInstallation(curBin, true);
+		} else {
+			inst = new RInstallation(metadataExtra.binpath, curBin === metadataExtra.binpath);
+		}


Implementing this new idea that most users probably want the current version of R, if they were running the current version R last time, even if current has incremented from, e.g., 4.3 to 4.4 in the meantime.

I opened #2659 for continued discussion.

I now know this was written down in #2535.

jmcphers · 2024-04-05T00:25:48Z

extensions/positron-r/src/constants.ts

@@ -6,3 +6,6 @@ import * as path from 'path';

 // The extension root directory.
 export const EXTENSION_ROOT_DIR = path.join(__dirname, '..');
+
+// The minimum supported version of R
+export const MINIMUM_R_VERSION = '4.2.0';


You could put it in the package.json file, which is readily readable in ts files via require and could also be consumed easily from outside them.

jmcphers · 2024-04-05T00:28:19Z

Feels like this addresses #2535 too -- do you agree?

jennybc · 2024-04-05T15:46:29Z

Feels like this addresses #2535 too -- do you agree?

YES. I remembered this, but apparently filed it away as a conversation and did not realize there was an actual issue. Thanks for connecting that.

Signed-off-by: Jennifer (Jenny) Bryan <[email protected]>

jmcphers

LGTM!

jennybc added 4 commits April 3, 2024 16:25

Introduce notion of an RInstallation being supported (or not)

9d3be3f

Filter out unsupported R versions and log any omitted R installations

0966648

Start to record more about an R installation's status relative to others

cce9c7a

Launch the current current version of R

b5b6281

jennybc commented Apr 4, 2024

View reviewed changes

jennybc marked this pull request as ready for review April 4, 2024 23:20

Remove (misconceived) check

4203ae6

jennybc requested a review from jmcphers April 4, 2024 23:26

jmcphers approved these changes Apr 5, 2024

View reviewed changes

jennybc changed the title ~~Flag, log, and omit unsupported R versions~~ Handle unsupported R versions; prefer current "current" version of R Apr 5, 2024

jennybc added 2 commits April 5, 2024 13:15

Put minimum R version in positron-r's package.json

3ce1cd3

Use EXTENSION_ROOT_DIR, it's sitting right there!

f3a1166

jennybc requested a review from jmcphers April 5, 2024 20:22

jennybc added 2 commits April 5, 2024 20:29

Merge branch 'main' into feature/flag-unsupported-r-versions

731c702

Signed-off-by: Jennifer (Jenny) Bryan <[email protected]>

Whitespace

8bcbe37

jennybc mentioned this pull request Apr 5, 2024

Should we offer a way to pin an R version for Positron, in a workspace? #2659

Open

jmcphers approved these changes Apr 5, 2024

View reviewed changes

jennybc merged commit 8785f43 into main Apr 5, 2024
1 check passed

jennybc deleted the feature/flag-unsupported-r-versions branch April 5, 2024 23:00

seeM mentioned this pull request Apr 8, 2024

Improve the UX when dropping support for language runtime versions #2690

Open

jennybc mentioned this pull request May 9, 2024

Allow workspaces to open with "the current version of R" without any fuss #2535

Closed

jmcphers mentioned this pull request Jun 14, 2024

No runtime starts if affiliated runtime is unavailable #1180

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Handle unsupported R versions; prefer current "current" version of R #2652

Handle unsupported R versions; prefer current "current" version of R #2652

jennybc commented Apr 4, 2024 •

edited

Loading

jennybc Apr 4, 2024 •

edited

Loading

jmcphers Apr 5, 2024

jennybc Apr 5, 2024

jennybc Apr 4, 2024 •

edited

Loading

jennybc Apr 4, 2024

jennybc Apr 5, 2024

jmcphers Apr 5, 2024

jmcphers commented Apr 5, 2024

jennybc commented Apr 5, 2024

jmcphers left a comment

Handle unsupported R versions; prefer current "current" version of R #2652

Handle unsupported R versions; prefer current "current" version of R #2652

Conversation

jennybc commented Apr 4, 2024 • edited Loading

QA notes

Main goal: stop offering to launch unsupported versions of R

Secondary goal: Keep launching the current version of R even if that changes

Secondary goal: Still possible to use non-current version of R

jennybc Apr 4, 2024 • edited Loading

Choose a reason for hiding this comment

jmcphers Apr 5, 2024

Choose a reason for hiding this comment

jennybc Apr 5, 2024

Choose a reason for hiding this comment

jennybc Apr 4, 2024 • edited Loading

Choose a reason for hiding this comment

jennybc Apr 4, 2024

Choose a reason for hiding this comment

jennybc Apr 5, 2024

Choose a reason for hiding this comment

jmcphers Apr 5, 2024

Choose a reason for hiding this comment

jmcphers commented Apr 5, 2024

jennybc commented Apr 5, 2024

jmcphers left a comment

Choose a reason for hiding this comment

jennybc commented Apr 4, 2024 •

edited

Loading

jennybc Apr 4, 2024 •

edited

Loading

jennybc Apr 4, 2024 •

edited

Loading