merge vscode-python upstream 2024.14.1
#4670
Conversation
isabelizimm
force-pushed
the
vscode-python-v2024.14.1
branch
from
1008760
to
6111b86
Compare
| // is the problem. We still need to make it thenable though. See this issue: https://github.com/florinn/typemoq/issues/67 | ||
| const result = TypeMoq.Mock.ofType<T>(targetCtor, behavior, shouldOverrideTarget, ...targetCtorArgs); | ||
| // --- Start Positron --- | ||
| // result.setup((x: any) => x.then).returns(() => undefined); |
There was a problem hiding this comment.
this line caused every single usage of this function to fail with TypeError: Cannot convert a Symbol value to a string-- I'm not sure why since it seems to be a community vetted way to mock things resolved as promises and works upstream 😩
| }); | ||
| // TODO @isabelizimm: HACK HACK HACK | ||
| // Replace the original `asRelativePath` method with the mock object | ||
| vscode.workspace.asRelativePath = mockAsRelativePath; |
There was a problem hiding this comment.
This was returning TypeError: Descriptor for property workspace is non-configurable and non-writable but if you stub the property asRelativePath instead of workspace, I hit TypeError: Cannot stub non-existent property asRelativePath instead. My workaround is to mock and then patch this
|
I played around with things very briefly, but if others can kick the tires, that would be much appreciated! (still todo: looks like the Tests on Linux is failing for Buffer Arrays, maybe needs an updated version?) |
isabelizimm
changed the title
vscode-python upstream 2024.14.1vscode-python upstream 2024.14.1
| @@ -254,6 +254,13 @@ jobs: | |||
| - name: Install test requirements | |||
| run: python -m pip install --upgrade -r build/test-requirements.txt | |||
|
|
|||
| - name: Rust Tool Chain setup | |||
There was a problem hiding this comment.
I don't think this should affect our build, but noting in case we should comment it out until we use the python-environment-tools Python locator
This applies changes from v2024.12.0, v2024.12.1, v2024.12.2, v2024.12.3, v2024.14.0, v2024.14.1.