Remove the setTimeout() + bindAll() hack

posit-dev · May 24, 2022 · 45398c8 · 45398c8
1 parent 1722948
commit 45398c8
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 11 deletions.
diff --git a/ipyshiny/static/output.js b/ipyshiny/static/output.js
diff --git a/js/src/output.ts b/js/src/output.ts
@@ -81,21 +81,12 @@ class IPyWidgetOutput extends Shiny.OutputBinding {
           }
         })
       });
-    });
+    }); 
   }
 }
 
 Shiny.outputBindings.register(new IPyWidgetOutput(), "shiny.IPyWidgetOutput");
 
-// By the time this code executes (i.e., by the time the `callback` in
-// `require(["@jupyter-widgets/html-manager"], callback)` executes, it seems to be too
-// late to register the output binding in a way that it'll "just work" for dynamic UI.
-// Moreover, when this code executes, dynamic UI when yet be loaded, so schedule
-// a bind to happen on the next tick.
-// TODO: this is a hack. Could we do something better?
-setTimeout(() => { Shiny.bindAll(document.body); }, 0);
-
-
 /******************************************************************************
 * Handle messages from the server-side Widget
 ******************************************************************************/