Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade TLS libraries and code #794

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

sarajmunjal
Copy link
Contributor

What

Upgraded tokio-rustls, rustls and rustls-pemfile to newer version
Also needed to add an import on rustls-pki-types because some constants are not available.

Why

Am trying to build pgcat inside a private repository with newer dependency versions.

Details

Because there were breaking changes, I had to follow some resources and examples from other projects.
https://github.com/rustls/rustls/releases/tag/v%2F0.22.0 - see Breaking Changes section.

Other examples

  1. https://github.com/rustls/rustls/blob/main/examples/src/bin/tlsclient-mio.rs
  2. https://github.com/rbatis/rbatis/blob/master/rbdc/src/net/tls/rustls.rs

Help needed

I could use some help with testing. Is there a testcase related to certs in the CI suite?

@drdrsh
Copy link
Collaborator

drdrsh commented Sep 5, 2024

I ran the the test suite against your PR, there are some linting issues there.

@sarajmunjal
Copy link
Contributor Author

Thanks, this was because I had run just update - that bumped up many things in the lockfile and led to deprecation warnings. I have undone this, and now the Cargo.lock change is bare minimum updates associated with Cargo.toml changes.

cargo clippy passes now.

Can we run tests again?

@sarajmunjal sarajmunjal marked this pull request as ready for review September 5, 2024 19:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants