Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Showheroes Bid Adapter : full rework of the adapter #12283

Open
wants to merge 21 commits into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 1 addition & 9 deletions modules/showheroes-bsBidAdapter.js
Original file line number Diff line number Diff line change
Expand Up @@ -49,14 +49,6 @@ const converter = ortbConverter({
}
return imp;
},
request(buildRequest, imps, bidderRequest, context) {
const req = buildRequest(imps, bidderRequest, context);
// delete user agent from oRTB, we'll get it from the header
(req?.device?.ua) && delete req.device['ua'];
// 'sua' is 2.6 standard, we operate with 2.5
(req?.device?.sua) && delete req.device['sua'];
return req;
},
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we decided to completely remove this logic instead?

So your server is okay with receiving both ua and sua ??

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, the server is ok with receiving both.

  • sua we don't support at the moment, but there is a plan to upgrade to 2.6, so at that point, we'll start using and we won't need to open another PR for our bidder.
  • ua we'll use it and as a fallback we'll use a header if ua is not provided.


bidResponse(buildBidResponse, bid, context) {
const bidResponse = buildBidResponse(bid, context);
Expand Down Expand Up @@ -132,7 +124,7 @@ export const spec = {
});
});
}
logInfo(`found urls to sync:`, syncs);

return syncs;
},

Expand Down
2 changes: 0 additions & 2 deletions test/spec/modules/showheroes-bsBidAdapter_spec.js
Original file line number Diff line number Diff line change
Expand Up @@ -116,8 +116,6 @@ describe('shBidAdapter', () => {
expect(payload.imp[0].bidfloorcur).eql('EUR');
expect(payload.imp[0].displaymanager).eql('Prebid.js');
expect(payload.site.page).to.eql('https://example.com/home');
expect(payload.device.ua).to.undefined;
expect(payload.device.sua).to.undefined;
});

describe('interpretResponse', function () {
Expand Down