-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Showheroes Bid Adapter : full rework of the adapter #12283
Open
FilipStamenkovic
wants to merge
21
commits into
prebid:master
Choose a base branch
from
showheroes:showheroes_bidder_update
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+289
−1,027
Open
Changes from 1 commit
Commits
Show all changes
21 commits
Select commit
Hold shift + click to select a range
5ae1867
switch to openRTB endpoint
FilipStamenkovic 5116cb0
refactor and add more tests
FilipStamenkovic 652d9d7
bring back original sync
FilipStamenkovic 3699703
read expired from the response
FilipStamenkovic 73aa688
remove unused sync url
FilipStamenkovic 250f310
read if netRevenue from response, include extra params
FilipStamenkovic 57fcb56
set displaymanager to prebid.js
FilipStamenkovic 194337d
update docs
FilipStamenkovic 8c45055
test is working
musikele 703bc80
don't merge pixel and iframe syncs
FilipStamenkovic 218a9a5
provide renderer
FilipStamenkovic e765a32
lint fix
FilipStamenkovic ab35904
remove banner support
FilipStamenkovic 9b7230d
switch to openRTB for response
FilipStamenkovic 44458b2
use fromORTB to simplify bidder
FilipStamenkovic 83fa22c
don't pass entire bid to renderer
FilipStamenkovic 5de5616
set video context in ext
FilipStamenkovic ec7fb62
endpoint should end with /
FilipStamenkovic 8c3b456
update documentation unitId
FilipStamenkovic b48ac3c
check if video features are enabled for tests
FilipStamenkovic 1ba2541
fix after review
FilipStamenkovic File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we decided to completely remove this logic instead?
So your server is okay with receiving both
ua
andsua
??There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, the server is ok with receiving both.
sua
we don't support at the moment, but there is a plan to upgrade to 2.6, so at that point, we'll start using and we won't need to open another PR for our bidder.ua
we'll use it and as a fallback we'll use a header ifua
is not provided.