Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce hwv parameter #774

Merged
merged 2 commits into from
Jun 21, 2024
Merged

Introduce hwv parameter #774

merged 2 commits into from
Jun 21, 2024

Conversation

ValentinPostindustria
Copy link
Collaborator

Issue #773.

Copy link
Collaborator

@jsligh jsligh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ValentinPostindustria looks good to me but can you add it to some of the test cases similar to what's been done in prebid/prebid-mobile-ios#1013 ?

@ValentinPostindustria
Copy link
Collaborator Author

It's already covered with the test in DeviceTest. This field existed before, but it wasn't set.

Copy link
Collaborator

@jsligh jsligh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@jsligh jsligh merged commit 45e2f28 into master Jun 21, 2024
5 checks passed
@jsligh jsligh deleted the feature/hwv_field branch June 21, 2024 13:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants