Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

agma: bugfixes #3495

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

agma: bugfixes #3495

wants to merge 2 commits into from
+136 −6

Conversation

steffenmllr
Copy link

@steffenmllr steffenmllr commented Oct 9, 2024 •
edited
Loading

🔧 Type of changes

  • bugfix

✨ What's the context?

Thanks @AntoxaAntoxic for the port of our adapter! During testing we found 2 minor bugs in the implementation-

  • 9da4ca8: prevents triggering a POST request when the buffer is empty. original
  • 2271af3: respect the sitesApp config and allow empty strings as publisherId, when the sitesApp is set. This also allows a publisher to set multiple codes for multiple sites/apps for the same publisherId. original test

Thanks again for the port!

@steffenmllr steffenmllr changed the title Check if the buffer has entries before flushing via timer agma: bugfixes Oct 9, 2024
@steffenmllr steffenmllr marked this pull request as ready for review October 15, 2024 08:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@steffenmllr