Tradplus #3508
Open
Tradplus #3508
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
AntoxaAntoxic
requested changes
Oct 16, 2024
|
|
||
| @Override | ||
| public Result<List<HttpRequest<BidRequest>>> makeHttpRequests(BidRequest bidRequest) { | ||
| final Map<ExtImpTradPlus, List<Imp>> extToImps = new HashMap<>(); |
There was a problem hiding this comment.
using a map here is an overhead since only one single imp is really utilized to retrieve the ext object, please get rid of it
Comment on lines
+96
to
+99
| private static List<Imp> removeFirstImpExt(List<Imp> imps) { | ||
| imps.set(0, imps.getFirst().toBuilder().ext(null).build()); | ||
| return imps; | ||
| } |
There was a problem hiding this comment.
this looks redundant since the list of imps always has a single imp
| public Result<List<BidderBid>> makeBids(BidderCall<BidRequest> httpCall, BidRequest bidRequest) { | ||
| try { | ||
| final BidResponse bidResponse = mapper.decodeValue(httpCall.getResponse().getBody(), BidResponse.class); | ||
| return Result.of(extractBids(bidResponse, httpCall.getRequest().getPayload()), Collections.emptyList()); |
There was a problem hiding this comment.
Result.withValues()
| import static org.prebid.server.proto.openrtb.ext.response.BidType.video; | ||
| import static org.prebid.server.proto.openrtb.ext.response.BidType.xNative; | ||
|
|
||
| public class TradPlusBidderTest extends VertxTest { |
There was a problem hiding this comment.
there is no any test that covers the outgoing http request:
- payload: the basic logic of using only a single imp ignoring others
- headers
- impIds object
| @@ -455,6 +455,8 @@ adapters.telaria.enabled=true | |||
| adapters.telaria.endpoint=http://localhost:8090/telaria-exchange/ | |||
| adapters.theadx.enabled=true | |||
| adapters.theadx.endpoint=http://localhost:8090/theadx-exchange | |||
| adapters.tradplus.enabled=true | |||
| adapters.tradplus.endpoint=http://localhost:8090/tradplus-exchange | |||
There was a problem hiding this comment.
please add the macros to the url to check them in the integration test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TradPlus is a leading, stable, and reliable ad monetization platform that is committed to providing global developers with fair, transparent and efficient monetization solutions. We also provide ADX and Saas ADX services. We serve 2,000+ global developers. Moreover, Our SDK has been certified by IAB Tech Lab and also joins Google Play SDK Index. And we have Information Security Management Certification.
Our advertising business spans the world. This is our official website: https://tradplusad.com/en. You can get more details about TradPlus.
this is TradPlus adapter version 1.0.
Thank!