fix: disallow dash in version (#1065)

prefix-dev · Sep 24, 2024 · 07fc8d8 · 07fc8d8
1 parent f2da23d
commit 07fc8d8
Showing 1 changed file with 11 additions and 0 deletions.
diff --git a/src/recipe/custom_yaml.rs b/src/recipe/custom_yaml.rs
@@ -1276,6 +1276,17 @@ impl TryConvertNode<VersionWithSource> for RenderedNode {
 
 impl TryConvertNode<VersionWithSource> for RenderedScalarNode {
     fn try_convert(&self, name: &str) -> Result<VersionWithSource, Vec<PartialParsingError>> {
+        let s = self.as_str();
+        if s.contains('-') {
+            // version is not allowed to contain a `-`
+            return Err(vec![_partialerror!(
+                *self.span(),
+                ErrorKind::InvalidValue((name.to_string(), "version cannot contain `-`".into())),
+                label = format!("version `{s}` cannot contain `-` "),
+                help = "replace the `-` with `_` or remove it"
+            )]);
+        }
+
         VersionWithSource::from_str(self.as_str())
             .map_err(|err| {
                 _partialerror!(