Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: typo of BasicHTTP result in json decode error #1007

Merged
merged 1 commit into from
Aug 5, 2024

Conversation

TTTPOB
Copy link
Contributor

@TTTPOB TTTPOB commented Aug 4, 2024

as title

@TTTPOB TTTPOB changed the title fix: typo of BasicHTTP result in json decode error doc: typo of BasicHTTP result in json decode error Aug 4, 2024
@TTTPOB
Copy link
Contributor Author

TTTPOB commented Aug 4, 2024

this deploy docs ci failed is not problem on my side, this is just a doc update.
I've looked into the doc produced by the generate-cli-docs command
doc for the generate-recipe subcommand disappears from the final doc, even when running the binary with explict feature specification cargo run --bin generate-cli-docs --features generate-cli-docs,recipe-generation > docs/reference/cli.md
as

  1. I am not familiar with clap-markdown
  2. this CI failing is not because of this PR

so I am not able to fix this

@wolfv
Copy link
Member

wolfv commented Aug 5, 2024

I'll have a look. Thanks for your PRs @TTTPOB!

@TTTPOB
Copy link
Contributor Author

TTTPOB commented Aug 5, 2024

Sorry, I made a mistake yestoday, branched from the old main, so the cli docs do not include generate-recipes. Today I have some spare time to check and found my mistake. Now it's good on my machine.

@TTTPOB TTTPOB reopened this Aug 5, 2024
@wolfv wolfv merged commit 7817d75 into prefix-dev:main Aug 5, 2024
19 of 32 checks passed
@wolfv
Copy link
Member

wolfv commented Aug 5, 2024

Excellent! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants