Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

0.288.1 docs #278

Merged
merged 1 commit into from
Aug 21, 2024
Merged

0.288.1 docs #278

merged 1 commit into from
Aug 21, 2024

Conversation

wanglinsong
Copy link
Member

No description provided.

Copy link

linux-foundation-easycla bot commented Aug 15, 2024

CLA Signed

The committers listed above are authorized under a signed CLA.

  • ✅ login: wanglinsong / name: Linsong Wang (1265f70)

@wanglinsong
Copy link
Member Author

@steveburnett please confirm docs has the correct link to the presto-server tgz file.

@steveburnett
Copy link

@steveburnett please confirm docs has the correct link to the presto-server tgz file.

@wanglinsong, are you referring to the "Manual/Local Download" pane (the upper left of the four download panes) on this branch's updated page replacing https://prestodb.io/getting-started/ on the website? I don't see any of the download panes in my local file:

See screenshot showing 0.288.1 and no download panes.
Screenshot 2024-08-15 at 2 25 24 PM

.
.
.
In the docs, in installation/deployment.html, the link to presto-server-0.288.1.tar.gz is correct: I successfully downloaded presto-server-0.288.1.tar.gz from that page (see screenshot):
Screenshot 2024-08-15 at 2 32 07 PM

@wanglinsong
Copy link
Member Author

the getting started page. please check the tgz file has the presto-ui jar included.

@steveburnett
Copy link

the getting started page. please check the tgz file has the presto-ui jar included.

As shown in the first screenshot in my comment, the Getting Started page does not have download links at all.

The tgz file that I downloaded from the link on installation/deployment.html has the file presto-ui-0.288.1.jar included.

@wanglinsong
Copy link
Member Author

This release has nothing to do with the getting started page.
Were there any updates for that page?
@alileclerc

Copy link

@steveburnett steveburnett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! (docs)

As @wanglinsong requested I check, the presto-server-0.288.1.tar.gz file that I downloaded from the link on installation/deployment.html has the file presto-ui-0.288.1.jar included.

The 0.288.1 Release Notes page is included in the doc update.

@steveburnett
Copy link

This release has nothing to do with the getting started page. Were there any updates for that page? @alileclerc

Okay, then I won't worry about the Getting Started page looking odd as shown in the screenshot.

The 0.288.1 release notes are where they should be in the doc, and the the presto-server-0.288.1.tar.gz file that I downloaded from the link on installation/deployment.html has the file presto-ui-0.288.1.jar included, so reviewed and approved.

@yhwang
Copy link
Member

yhwang commented Aug 20, 2024

FYI, @wanglinsong my previous PR is not merged yet #277
Landing this PR will remove the old archived releases since I only manually added them to the master branch earlier.

EDIT
@tdcmeehan merged #277. I found another issue with the node version and created #279 to fix it. @tdcmeehan merged this fix too. Thanks

@wanglinsong wanglinsong merged commit 45eb2ed into prestodb:source Aug 21, 2024
3 checks passed
@wanglinsong wanglinsong deleted the 0.288.1-docs branch August 21, 2024 06:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants