Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: v3 #307

Draft
wants to merge 15 commits into
base: master
Choose a base branch
from
Draft

feat: v3 #307

wants to merge 15 commits into from

Conversation

wolfy1339
Copy link
Contributor

@wolfy1339 wolfy1339 commented Aug 23, 2024

BREAKING CHANGE: This package has now migrated to ESM only
BREAKING CHANGE: The properties of the Client class are now private

Uzlopak and others added 4 commits August 22, 2024 16:23
index.ts Outdated Show resolved Hide resolved
Copy link
Collaborator

@Uzlopak Uzlopak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We could make the properties of SmeeClient like source, target etc. private by prefixing with '#`. Maybe rename events with to eventsource?

Like this.
image

index.ts Outdated Show resolved Hide resolved

This comment has been minimized.

This comment was marked as off-topic.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants