Ensures the display of containers only changes the case of first character. #1442
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
randalldfloyd
changed the title
seanaery
requested changes
Dec 7, 2023
There was a problem hiding this comment.
Thanks for working on this @randalldfloyd . My apologies -- I see the example customization I had shared before was missing a corresponding rspec test. Can you modify/supplement the spec for #containers here as part of this PR to show different cases in action?:
https://github.com/projectblacklight/arclight/blob/main/spec/models/concerns/arclight/solr_document_spec.rb#L90-L96
|
@seanaery Thanks! Yes I also got to thinking that I should add a spec for it after I took the draft status off of it. |
marlo-longley
approved these changes
Dec 7, 2023
seanaery
approved these changes
Dec 7, 2023
bonniegee
pushed a commit
that referenced
this pull request
Dec 13, 2023
…acter. (#1442) * Ensures containers display only changes case of first character. * Adjusting #containers in SolrDocument spec to test capitalization.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1433
Changes the display of containers, which currently uses
.capitalize, to only change the first character but leave subsequent characters unchanged.