Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes missing _html_tesm fields and <notes> #1500

Merged
merged 2 commits into from
Dec 18, 2023
Merged

Fixes missing _html_tesm fields and <notes> #1500

merged 2 commits into from
Dec 18, 2023

Conversation

gwiedeman
Copy link
Contributor

Now displays component fields correctly, which Closes #1451, Closes #1450, and Closes #1459. They all now display at

This also handles many <note> elements both inside and and outside of collection and component <did> elements, which Closes #1467

@seanaery
Copy link
Contributor

Just need a quick fix here re: the did/note element... rather than add it individually as did_note_ssm, it would be best to add it to the DID_SEARCHABLE_NOTES array here and here.

That way it would get collected in note_html_tesm field regardless of whether it was situated in the did. It'd also get the to_text: false rule which would preserve any XML tags nested within the note for further processing through the render_html_tags helper. E.g., if the note really did say to contact us and provided an extref link to do that, the link would work.

Then you also wouldn't have to add a did_note field to config.add_background_field & config.add_component_field, you'd already be covered by note.

@gwiedeman
Copy link
Contributor Author

Ah, yes I didn't think of that. The component did/note was is already broken out, I guess to compartmentalize if you have one note in the <did> and one outside it, but I don't know of a use case where that;s meaningful, so I think I agree to just add them to the same field.

@lfarrell lfarrell merged commit 7922386 into main Dec 18, 2023
4 checks passed
@lfarrell lfarrell deleted the add_notes branch December 18, 2023 19:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants