Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Apply bootstrap style to title with classes instead of sass extend #3199

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 0 additions & 4 deletions app/assets/stylesheets/blacklight/_search_results.scss
Original file line number Diff line number Diff line change
Expand Up @@ -6,10 +6,6 @@
margin-top: $spacer;
padding-top: $spacer;

.document-title-heading {
@extend h5;
}

.document-main-section {
flex-grow: 1;
}
Expand Down
3 changes: 2 additions & 1 deletion app/components/blacklight/document_title_component.rb
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,8 @@ class DocumentTitleComponent < Blacklight::Component
renders_many :actions

# rubocop:disable Metrics/ParameterLists
def initialize(title = nil, document: nil, presenter: nil, as: :h3, counter: nil, classes: 'index_title document-title-heading col', link_to_document: true, document_component: nil, actions: true)
def initialize(title = nil, document: nil, presenter: nil, as: :h3, counter: nil, classes: 'index_title document-title-heading col h5', link_to_document: true, document_component: nil,
actions: true)
raise ArgumentError, 'missing keyword: :document or :presenter' if presenter.nil? && document.nil?

@title = title
Expand Down
Loading