Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test using the supported way of compiling sass #3210

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Test using the supported way of compiling sass #3210

wants to merge 3 commits into from

Conversation

jcoyne
Copy link
Member

@jcoyne jcoyne commented Jun 20, 2024

There are warnings about sassc-rails being not supported since 2019 in https://guides.rubyonrails.org/asset_pipeline.html#cssbundling-rails

In rails 6:

The file /home/runner/work/blacklight/blacklight/.internal_test_app/app/assets/stylesheets/application.bootstrap.scss does not appear to exist

In rails 7.0:

$ esbuild app/javascript/*.* --bundle --sourcemap --format=esm --outdir=app/assets/builds --public-path=/assets
Error: R] No matching export in "node_modules/bootstrap/dist/js/bootstrap.esm.js" for import "default"

    app/javascript/application.js:5:7:
      5 │ import bootstrap from "bootstrap"
        ╵        ~~~~~~~~~

@jcoyne jcoyne force-pushed the css-sass branch 9 times, most recently from 7aec97a to 3e32c58 Compare June 20, 2024 20:53
@jcoyne jcoyne force-pushed the css-sass branch 7 times, most recently from 20bdfcc to abf1dc5 Compare July 18, 2024 16:08
@jcoyne jcoyne added this to the 9.X milestone Sep 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant