Improve how adv search handles incoming params

[mamrey]

closes #3237, #3238

Changes

• excludes adv search form parameters from hidden search fields to prevent duplicate query params
• pre selects facet appropriate facet checkbox only when receiving inclusive filter parameters
  • implements check using new FacetCheckboxItemPresenter that overrides #selected?
• increases spec coverage when prepopulating adv search form
• adds specs for new presenter

Questions

I have a couple lingering questions that would help clarify my understanding of the expected behavior of the adv search and provide additional context for a review:

Currently, incoming exclusive filter parameters will pre-check the corresponding facet checkbox. This PR prevents this behavior, and now any incoming exclusive filters will continue to be added as a hidden field. What is the desired behavior around incoming exclusive filters? In my opinion, the facet checkboxes represent inclusive filters, so it's a bit misleading to have them pre selected with an incoming exclusive filter. Any thoughts on this?

Currently, we exclude incoming inclusive parameters from the displayed constraints on the adv search page. This PR does not change this, but is this desired behavior?

[tampakis]

Currently, we exclude incoming inclusive parameters from the displayed constraints on the adv search page. This PR does not change this, but is this desired behavior?

I think the inclusive facet parameters should also carry over. Could we track adding that capability in a separate issue?

resoved issue

[cgalarza]

Currently, we exclude incoming inclusive parameters from the displayed constraints on the adv search page. This PR does not change this, but is this desired behavior?

I think the inclusive facet parameters should also carry over. Could we track adding that capability in a separate issue?

@mamrey and I discussed this and we think we should only display parameters that are not already selected on the form in the displayed constraints at the top of the advanced search form. The inclusive facet parameters will be selected on the advanced search form so there isn't a need to display them again in the displayed constraints. @mamrey is going to write up a ticket explaining this issue in more detail.