Override ViewComponent::Base#sidecar_files instead of the compiler. #3346
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cbeer
force-pushed
the
vc315-sidecar-files
branch
4 times, most recently
from
c68be30
to
b5822b9
Compare
cbeer
force-pushed
the
vc315-sidecar-files
branch
from
b5822b9
to
d06d115
Compare
jcoyne
approved these changes
Sep 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
At the time
Blacklight::Componentwas implemented,sidecar_fileswas an experimental API. As of view_component 2.74, it was promoted to a stable API. As far as I can tell, the potential instability was the primary motivation for the customCompiler, but ViewComponent 3.15 totally rewrote the compiler so maybe it was less stable than expected 🤷♂️