Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#177] Add information about basing new PRs against 'develop' to README #222

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from

Conversation

shaniphankar
Copy link

@shaniphankar shaniphankar commented Oct 17, 2017

This PR adds the information that PRs should be based against develop to the README.

Closes: #177

Mention in docs to base PRs against 'develop' branch
Added newline before heading
@jtojnar
Copy link
Member

jtojnar commented Oct 17, 2017

Thanks for the update, unfortunately there are still some issues. You can view them by clicking details next to the “Travis CI build failed” bar below. In particular there are some spaces at the end of a line:

/hamster-gtk/CONTRIBUTING.rst:101: D002 Trailing whitespace

We also need you to accept the contributor license agreement to prevent certain legal issues. See also Why CLA? document.

@elbenfreund elbenfreund changed the title Shaniphankar patch 2 [#177] Add information about basing new PRs against 'develop' to README Oct 19, 2017
@elbenfreund elbenfreund added this to the 0.12.0 milestone Oct 19, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants