Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Ruff as supported tool #694

Merged
merged 1 commit into from
Oct 25, 2024
Merged

Add Ruff as supported tool #694

merged 1 commit into from
Oct 25, 2024

Conversation

sbrunner
Copy link
Member

@sbrunner sbrunner commented Oct 25, 2024

Description

Add Ruff as supported tool

I also modified the pylint output to:

  • Avoid having a None in the message
  • Add the character if available
  • Be stronger
  • Be more like the pylint output

And the profile merge to be able to better activate deactivate feature from inherited template, then I do a deep merge of the dictionaries that's in the option.

Related Issue

Fix #601

How Has This Been Tested?

On prospector code

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

@sbrunner sbrunner added this to the 1.13.0 milestone Oct 25, 2024
@sbrunner sbrunner changed the title Add Ruff ass supported tool Add Ruff as supported tool Oct 25, 2024
@sbrunner sbrunner marked this pull request as ready for review October 25, 2024 09:40
docs/profiles.rst Outdated Show resolved Hide resolved
Copy link
Collaborator

@Pierre-Sassoulas Pierre-Sassoulas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, some questions to make sure we thought about it, but this is mergeable as is imo.

.prospector.yml Outdated Show resolved Hide resolved
pyproject.toml Outdated Show resolved Hide resolved
Copy link
Collaborator

@Pierre-Sassoulas Pierre-Sassoulas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You're making prospector enter the second half of the twenties @sbrunner !

@carlio
Copy link
Contributor

carlio commented Oct 25, 2024

You're making prospector enter the second half of the twenties @sbrunner !

Now I feel old :)

@sbrunner sbrunner merged commit bab605b into master Oct 25, 2024
5 checks passed
@sbrunner sbrunner deleted the add-ruff branch October 25, 2024 14:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEATURE REQUEST] Add support for ruff
3 participants