refactor: switch to *Python*'s official tomllib
, as toml
cannot parse inline table values properly
#46
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks for this library.
I use Prospector often, which makes use of this library. In Prospector I often use inline tables, like:
This cannot be parsed by the
toml
library, which this library uses. As you can see in https://github.com/uiri/toml/blob/0.10.2/toml/decoder.py#L654:The parsing is really basic and is clearly going to tail. It assumes inline tables are all in one line.
This file was last updated 2020/10/30 so seems rather dead.
This bug is also mentioned at uiri/toml#348, quite some time ago.
Python now has a native Toml library, so it makes sense to switch to that. The API seems quite compatible, as I only had to switch the library, and all tests still pass.