Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support comparison of message embed structs #45

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

tamayika
Copy link

@tamayika tamayika commented Aug 7, 2024

closes golang/protobuf#1638

This fixes panics on comparison of message embed structs.
Previously, message embed struct is treated as message.
There were two problems.

  • When embed message is nil, panics on proto reflection.
  • When embed message is not nil but other field is different, cmp.Equal return true.

@puellanivis
Copy link

Thank you for your interest into contributing to this project.

Unfortunately this project does not accept GitHub pull requests as the source-of-truth for this project is hosted at https://go.googlesource.com/protobuf. This project page on GitHub is a mirror of that other repository.

If you would like to contribute to this project, please follow the contribution guidelines for instructions on how to send a change. If the change you'd like to make is more substantial or introduces any new features, then it should first be discussed on the issue tracker.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

protocmp: Panic on embed message field comparison
2 participants