Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Freshen up support tooling. #222

Draft
wants to merge 11 commits into
base: master
Choose a base branch
from
Draft

Freshen up support tooling. #222

wants to merge 11 commits into from

Commits on Jun 25, 2020

  1. Add some more debug logging for FileCache and for the pass-through path. 

    This makes it easier to figure out _why_ something fails to look up altogether.
    @Flameeyes
    Flameeyes committed Jun 25, 2020
    Configuration menu
    Copy the full SHA
    0763108 View commit details
    Browse the repository at this point in the history

  2. Make Serializer.dumps() require a body parameter. 

    When caching permanent redirects, if `body` is left to `None`, there's an infinite recursion that will lead to the caching to silently fail and not cache anything at all.

So instead, make `body` a required parameter, which can be empty (`''`) for cached redirects.
    @Flameeyes
    Flameeyes committed Jun 25, 2020
    Configuration menu
    Copy the full SHA
    5ac1251 View commit details
    Browse the repository at this point in the history

  3. Add an explicit encoding to test_chunked_response. 

    This is to workaround an isort bug that appears fixed in master, where the Transfer-Encoding: chunked line is interpreted as an encoding for the file.
    @Flameeyes
    Flameeyes committed Jun 25, 2020
    Configuration menu
    Copy the full SHA
    46b1f3c View commit details
    Browse the repository at this point in the history

  4. Use [isort](https://github.com/timothycrosley/isort) throughout the s… 

    …ource.
    @Flameeyes
    Flameeyes committed Jun 25, 2020
    Configuration menu
    Copy the full SHA
    dea9cf5 View commit details
    Browse the repository at this point in the history

  5. Refresh [black](https://github.com/psf/black) formatting.

    @Flameeyes
    Flameeyes committed Jun 25, 2020
    Configuration menu
    Copy the full SHA
    545c5e3 View commit details
    Browse the repository at this point in the history

  6. Set up [pre-commit](https://pre-commit.com/). 

    This includes isort, black and some basic hygiene on text files.
    @Flameeyes
    Flameeyes committed Jun 25, 2020
    Configuration menu
    Copy the full SHA
    190d7de View commit details
    Browse the repository at this point in the history

  7. Add *~ to gitignore. 

    This is a fairly common unix extension for backup files used at least by Emacsen and vim.
    @Flameeyes
    Flameeyes committed Jun 25, 2020
    Configuration menu
    Copy the full SHA
    03d034f View commit details
    Browse the repository at this point in the history

  8. Use six instead of manually maintaining compatibility with PY2. 

    This makes it easier to use constants for status codes as well.
    @Flameeyes
    Flameeyes committed Jun 25, 2020
    Configuration menu
    Copy the full SHA
    0fe4cd0 View commit details
    Browse the repository at this point in the history

  9. Make the project compliant with the REUSE guidelines. 

    See https://reuse.software/ for details.
    @Flameeyes
    Flameeyes committed Jun 25, 2020
    Configuration menu
    Copy the full SHA
    f3d0098 View commit details
    Browse the repository at this point in the history

  10. Make the BaseCache class an abstract class. 

    This is just a matter of cleanup, I can't think of any good reason for this
_not_ to be marked abstract.
    @Flameeyes
    Flameeyes committed Jun 25, 2020
    Configuration menu
    Copy the full SHA
    f75db54 View commit details
    Browse the repository at this point in the history

  11. Suppress errors for os.makedirs(), again. 

    This is a bit more nuanced in Python 3, where only EEXIST errors are
suppressed, to match the `delete` codepath.
    @Flameeyes
    Flameeyes committed Jun 25, 2020
    Configuration menu
    Copy the full SHA
    15b7041 View commit details
    Browse the repository at this point in the history