[Nomad] Update Consul & Fix Permissions #5369
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hackartisan
previously requested changes
Sep 20, 2024
Sure, that's a good idea. It's gonna expand this PR a fair bit. |
Done. |
eliotjordan
approved these changes
Sep 20, 2024
The nomad permissions template wasn't the recommended template from https://developer.hashicorp.com/nomad/docs/integrations/consul/acl. This fixes that, and also updates Consul.
tpendragon
force-pushed
the
update_consul
branch
from
844eb6a
to
c8bc97e
Compare
tpendragon
dismissed
hackartisan’s stale review
Added the server/client policy split.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The nomad permissions template wasn't the recommended template from https://developer.hashicorp.com/nomad/docs/integrations/consul/acl. This fixes that, and also updates Consul.
This also moves secrets for Nomad to its own vault file.