WIP: Enum new PUP-10944

[nod0n]

https://tickets.puppetlabs.com/browse/PUP-10944

[puppetlabs-jenkins]

Can one of the admins verify this patch?

[CLAassistant]

All committers have signed the CLA.

[joshcooper]

Hi @nod0n, thanks for your contribution! I read through the slack conversation, about wanting something like bool2str from stdlib. If I understand correctly, you want to take a boolean (or integer) as input and have it select among multiple boolean-like values (yes, no, etc), for example:

notice(convert(['no', 'yes'], true))

If so I'm not sure adding Enum.new will do that, but I may be misunderstanding. For example, I took your PR and added the following:

       end
 
       dispatch :from_args do
+        param          'Array', :values
         param          'Selector', :selector      # selects one of the Enum's strings
         optional_param 'Format',   :string_format # how should the string being formatted?
       end
 
-      def from_args(selector, format = :default)
+      def from_args(values, selector, format = :default)
         string = case selector
-          when true then @values[1]
-          when false then @values[0]
-          when Integer then @values[selector]
+          when true then values[1]
+          when false then values[0]
+          when Integer then values[selector]
           end
 
         StringConverter.singleton.convert(string, format)

However that fails, because Enum.new is supposed to return an instance of an Enum, not a String:

$ bx puppet apply -e 'notice(Enum.new(["no", "yes"], true))'
Error: Evaluation Error: Error while evaluating a Method call, Converted value from Enum.new() has wrong type, expects a match for Enum, got 'yes' (line: 1, column: 16) on node localhost

Based on your original comments in slack:

but is it also possible to set custom value for true , like with bool2str

makes me think you really do want to implement String.new(["no", "yes"], true)? Thoughts @hlindberg?

[hlindberg]

An ”instance of Enum” is actually a ruby string so that should work. There are never any instances of any other ”enum type” passed around. The check in new impl that of the return value’s type could be wrong for Enum - probably because Enum did not have a new before this so has gone untested for that case. I looked briefly at String new, and as I recall it was difficult to make it support the proposed “pick string from array or enum based on value”. I could be wrong though. - henrik

…

1 sep. 2021 kl. 01:12 skrev Josh Cooper ***@***.***>:  Hi @nod0n, thanks for your contribution! I read through the slack conversation, about wanting something like bool2str from stdlib. If I understand correctly, you want to take a boolean (or integer) as input and have it select among multiple boolean-like values (yes, no, etc), for example: notice(convert(['no', 'yes'], true)) If so I'm not sure adding Enum.new will do that, but I may be misunderstanding. For example, I took your PR and added the following: end dispatch :from_args do + param 'Array', :values param 'Selector', :selector # selects one of the Enum's strings optional_param 'Format', :string_format # how should the string being formatted? end - def from_args(selector, format = :default) + def from_args(values, selector, format = :default) string = case selector - when true then @values[1] - when false then @values[0] - when Integer then @values[selector] + when true then values[1] + when false then values[0] + when Integer then values[selector] end StringConverter.singleton.convert(string, format) However that fails, because Enum.new is supposed to return an instance of an Enum, not a String: $ bx puppet apply -e 'notice(Enum.new(["no", "yes"], true))' Error: Evaluation Error: Error while evaluating a Method call, Converted value from Enum.new() has wrong type, expects a match for Enum, got 'yes' (line: 1, column: 16) on node localhost Based on your original comments in slack: but is it also possible to set custom value for true , like with bool2str makes me think you really do want to implement String.new(["no", "yes"], true)? Thoughts @hlindberg? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or unsubscribe. Triage notifications on the go with GitHub Mobile for iOS or Android.

[joshcooper]

An ”instance of Enum” is actually a ruby string so that should work

Ahh, ok I'll take a look

[joshcooper]

When the selector is an Integer we should assert that it's between 0 <= selector < @values.length and raise ArgumentError if it's not. Similarly, we should have an else clause and raise if since it's not supported. We do something similar when creating floats:

raise ArgumentError, _("Illegal radix: %{radix}, expected 2, 8, 10, 16, or default") % { radix: radix }