-
Notifications
You must be signed in to change notification settings - Fork 246
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add ICC profiles to PDFs #709
Conversation
@Lucas-C I don't have a Winows machine so I couldn't update |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @eroux
Thank you for taking the time to work on this!
That's a very valuable addition for fpdf2
🥳😀
Sure, but I just ran unit test By the way, you may want to get rid of |
My bad, I did not run the test correctly... 🤦♂️ I generated a reference PDF file, but I got this error when performing
You can either allow me push to your fork: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/working-with-forks/allowing-changes-to-a-pull-request-branch-created-from-a-fork Or use the PDF file included with this comment: |
Apart from the nice mention you already added in In order to mention this automatic inclusion of ICC profiles from images, and also how to remove /alter ICC profiles: |
thanks for the PDF, I've pushed it. I'm working on the two changes but I just wanted to say that updating I'm thinking also that perhaps releasing a new version with those changes could be a good option? The changes since the last version are pretty significant for use cases involving images |
I agree. In the meantime, you can still use the latest
|
I think it should be ok now |
Merged! |
amazing, thanks! |
Fixes #697
The GitHub pipeline is OK (green),
meaning that both
pylint
(static code analyzer) andblack
(code formatter) are happy with the changes of this PR.A unit test is covering the code added / modified by this PR
This PR is ready to be merged
In case of a new feature, docstrings have been added, with also some documentation in the
docs/
folderA mention of the change is present in
CHANGELOG.md
By submitting this pull request, I confirm that my contribution is made under the terms of the GNU LGPL 3.0 license.