Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reducing fonttools memory usage by 10MiB by passing lazy=True to TTFont constructor #718

Merged
merged 2 commits into from
Mar 10, 2023

Conversation

Lucas-C
Copy link
Member

@Lucas-C Lucas-C commented Mar 10, 2023

This was spotted while investigating this issue: #641 (comment)

@codecov
Copy link

codecov bot commented Mar 10, 2023

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (f8de21c) 93.75% compared to head (003e2f4) 93.75%.

❗ Current head 003e2f4 differs from pull request most recent head 09193a2. Consider uploading reports for the commit 09193a2 to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #718   +/-   ##
=======================================
  Coverage   93.75%   93.75%           
=======================================
  Files          26       26           
  Lines        7009     7009           
  Branches     1258     1258           
=======================================
  Hits         6571     6571           
  Misses        260      260           
  Partials      178      178           
Impacted Files Coverage Δ
fpdf/output.py 96.65% <ø> (ø)
fpdf/fpdf.py 91.92% <100.00%> (ø)
fpdf/svg.py 98.30% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@Lucas-C Lucas-C merged commit 35d8e7a into master Mar 10, 2023
@Lucas-C Lucas-C deleted the fonttools-memory-optim branch June 14, 2023 11:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant