Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

write_html: do not style header row if no <th> is present - fix #740 #766

Merged
merged 1 commit into from
Apr 12, 2023

Conversation

Lucas-C
Copy link
Member

@Lucas-C Lucas-C commented Apr 12, 2023

This PR also introduces some tests files that I wrote in #703 but forgot to git add before... 🤦‍♂️

@codecov
Copy link

codecov bot commented Apr 12, 2023

Codecov Report

Patch coverage: 30.00% and project coverage change: -0.09 ⚠️

Comparison is base (393580e) 92.67% compared to head (36a8fe4) 92.58%.

❗ Current head 36a8fe4 differs from pull request most recent head ef1c7d7. Consider uploading reports for the commit ef1c7d7 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #766      +/-   ##
==========================================
- Coverage   92.67%   92.58%   -0.09%     
==========================================
  Files          27       27              
  Lines        7275     7283       +8     
  Branches     1317     1320       +3     
==========================================
+ Hits         6742     6743       +1     
- Misses        337      341       +4     
- Partials      196      199       +3     
Impacted Files Coverage Δ
fpdf/html.py 86.13% <22.22%> (-1.49%) ⬇️
fpdf/table.py 84.83% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@Lucas-C Lucas-C merged commit be36d95 into master Apr 12, 2023
@Lucas-C Lucas-C deleted the issue-740 branch April 12, 2023 17:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant