Stop regenerating mirror_multi_cell.pdf on every test-run #866
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tests failed as a step completed too quickly. I don't think this is related to this PR. Re-running tests will probably fix this. |
Lucas-C
reviewed
Jul 25, 2023
| @@ -177,5 +177,4 @@ def test_mirror_multi_cell(tmp_path): | |||
| draw_mirror_line(pdf, (pdf.epw / 2, pdf.eph), "SOUTH") | |||
| pdf.multi_cell(w=120, txt=LOREM_IPSUM[:120], fill=True, border=1) | |||
|
|
|||
| pdf.output(HERE / "mirror_multi_cell.pdf") | |||
There was a problem hiding this comment.
Well spotted! 👍
I missed this in PR https://github.com/PyFPDF/fpdf2/pull/783/files#diff-36dddae084ca8281e723807aba6ca2d1c6c83bad24ec7b2d565668e71a8c9f80R169
Lucas-C
approved these changes
Jul 25, 2023
|
Indeed, re-running the failed tests fixed the issue. Merged, thank you @Tolker-KU! You are on a good run of contributions ^^ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist:
The GitHub pipeline is OK (green),
meaning that both
pylint(static code analyzer) andblack(code formatter) are happy with the changes of this PR.A unit test is covering the code added / modified by this PR
This PR is ready to be merged
In case of a new feature, docstrings have been added, with also some documentation in the
docs/folder "N/A"A mention of the change is present in
CHANGELOG.md"N/A"By submitting this pull request, I confirm that my contribution is made under the terms of the GNU LGPL 3.0 license.