Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use cell_fill_mode #879

Merged
merged 1 commit into from
Aug 11, 2023
Merged

use cell_fill_mode #879

merged 1 commit into from
Aug 11, 2023

Conversation

jankobler
Copy link

cell_fill_logic is no longer an argument of Table

see https://py-pdf.github.io/fpdf2/fpdf/table.html#fpdf.table.Table

Checklist:

  • The GitHub pipeline is OK (green),
    meaning that both pylint (static code analyzer) and black (code formatter) are happy with the changes of this PR.

  • A unit test is covering the code added / modified by this PR

  • This PR is ready to be merged

  • In case of a new feature, docstrings have been added, with also some documentation in the docs/ folder

  • A mention of the change is present in CHANGELOG.md

By submitting this pull request, I confirm that my contribution is made under the terms of the GNU LGPL 3.0 license.

cell_fill_logic is no longer an argument of Table

see https://py-pdf.github.io/fpdf2/fpdf/table.html#fpdf.table.Table

Signed-off-by: Jan Kobler <[email protected]>
@jankobler jankobler requested a review from Lucas-C as a code owner August 9, 2023 22:06
@Lucas-C Lucas-C merged commit f25f916 into py-pdf:master Aug 11, 2023
10 checks passed
@Lucas-C
Copy link
Member

Lucas-C commented Aug 11, 2023

Thank you @jankobler for this fixup! 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants