Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create hook-coincurve #659

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Conversation

earonesty
Copy link

coincurve hooks, tested osx/linux/windows

coincurve hooks, tested osx/linux/windows
Copy link
Member

@rokm rokm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please also add a basic import test here, and add coincurve==18.0.0 to requirements-test-libraries.txt so that CI will run the added test.

package_path = get_package_paths('coincurve')[0]

# Collect data files
datas = collect_data_files('coincurve')
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What data files are there to collect?

datas.append((libsecp256k1_path, 'coincurve'))
break

assert libsecp256k1_path, f"can't find coincurve libsecp256k1, look in {coincurve_path} and then modify this hook"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any reason this is not using binaries = collect_dynamic_libs('coincurve')? This should pick up the DLL on Windows.

On linux and macOS, _libsecp256k1 seems to be an extension and should be picked up automatically.

@earonesty
Copy link
Author

earonesty commented Nov 3, 2023 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants