Rename checkers/async.py to async_checker.py to import from another module

[bgb10]

Type of Changes

	Type
✓	🔨 Refactoring

Description

Hi. Thank you for maintaining this great library :)
I wanted to make test code for async checkers, but since name of async checker is async.py, AsyncChecker class in this file cannot be imported anywhere. ('async' is keyword!) Indeed, we imported this nowhere before (just registered checker to linter as below), but to write test code for AsyncChecker, file rename is must.

def register(linter: PyLinter) -> None:
    linter.register_checker(AsyncChecker(linter))

After this PR merged, I'll want to make unit test code for AsyncChecker and adding some functionality.

[Pierre-Sassoulas]

Thank you for opening the PR. Let's merge this but also if you want to add tests for the async checker functional tests already exists and are nicer to use imo. :)

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (main@15a5ac0). Learn more about missing BASE report.
Report is 6 commits behind head on main.

Additional details and impacted files

@@           Coverage Diff           @@
##             main   #10060   +/-   ##
=======================================
  Coverage        ?   95.80%           
=======================================
  Files           ?      174           
  Lines           ?    18959           
  Branches        ?        0           
=======================================
  Hits            ?    18163           
  Misses          ?      796           
  Partials        ?        0           

Files with missing lines	Coverage Δ
pylint/checkers/async_checker.py	97.72% <ø> (ø)

[DanielNoord]

This should probably have a breaking news fragment as it is breaking change.

[jacobtylerwalls]

Is it breaking if there was no way to import it by name before?

[DanielNoord]

Can't you use importlib? pylint itself has found a way to use this checker, so downstream users might have as well

[jacobtylerwalls]

Then does pylint need to change anything?

[jacobtylerwalls]

Ah I see this is mentioned in the body:

Indeed, we imported this nowhere before

Agree a breaking fragment would
Be good.

[bgb10]

Thanks for review everybody 👍🏻
yeah it is possible to use importlib, but I think it would be much better to prevent using filename as same as identifier.
Does this PR would be deferred until milestone 4.0.0?
I want to write test codes for AsyncChecker, so I don't want this PR to be blocker 😄

[jacobtylerwalls]

It's not a blocker, 4.0 is the current version under development.

[Pierre-Sassoulas]

(I approved because I thought like Jacob that it was impossible to import so it did not break anything). Considering Daniel's point, do you mind adding a changelog @bgb10 ?

[bgb10]

@Pierre-Sassoulas Added :)

[github-actions]

🤖 According to the primer, this change has no effect on the checked open source code. 🤖🎉

This comment was generated for commit 41126dd

[Pierre-Sassoulas]

Thank you,for noticing and fixing this ! (Autofix of 'noticing' to 'nothing'... mobile is dangerous, huhu)