(proposal) Always use the suggestion mode for no-member / c-extension-no-member
#9962
+16
−54
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
DanielNoord
reviewed
Sep 25, 2024
| @@ -1202,24 +1178,24 @@ def _get_nomember_msgid_hint( | |||
| node: nodes.Attribute | nodes.AssignAttr | nodes.DelAttr, | |||
| owner: SuccessfulInferenceResult, | |||
| ) -> tuple[Literal["c-extension-no-member", "no-member"], str]: | |||
| suggestions_are_possible = self._suggestion_mode and isinstance( | |||
| owner, nodes.Module | |||
| if isinstance(owner, nodes.Module) and _is_c_extension(owner): | |||
There was a problem hiding this comment.
_is_c_extension already checks isinstance(..., Module).
| return "c-extension-no-member", "" | ||
| if not self.linter.config.missing_member_hint: | ||
| return "no-member", "" | ||
| names = _similar_names( |
There was a problem hiding this comment.
Could you share a profile run for a project like pylint or astroid and let us know the total time spent in _similar_names? That might impact whether we want to lru_cache it, potentially after fiddling with when attname is filtered out. Let me know if I'm speaking in too much shorthand.
Pierre-Sassoulas
force-pushed
the
remove-suggestion-mode-option-we-always-suggest
branch
from
b370363
to
7a7170f
Compare
|
🤖 According to the primer, this change has no effect on the checked open source code. 🤖🎉 This comment was generated for commit 7a7170f |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of Changes
Description
Work in progress to know what others think. There's no reason to add to not suggest imo (?), so we can remove the option too in the spirit of simplification.