Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update non PEP 440 wheel filename deprecation notice #12939

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

notatallshaw
Copy link
Member

@notatallshaw notatallshaw commented Aug 25, 2024

As requested in #12918 (comment) this creates an issue and points to the deprecation notice to that issue (#12938).

Further, upon testing pip main for a little bit I found several packages that use _ to separate the version and build number, which is valid, but the deprecation was pretty noisey as the current logic can't distinguish this, so I updated the deprecation to not fire unless parse_wheel_filename identified it as invalid.

E.g
$ pip install --dry-run marshmallow==1.0.0
  DEPRECATION: Wheel filename 'marshmallow-1.0.0_a-py2.py3-none-any.whl' uses an invalid filename format, as the version part '1.0.0_a' is not correctly normalised, and contains an underscore character. Future versions of pip may fail to recognise this wheel. pip 25.1 will enforce this behaviour change. A possible replacement is rename the wheel to use a correctly normalised version part (this may require updating the version in the project metadata). Discussion can be found at https://github.com/pypa/pip/issues/12914
Collecting marshmallow==1.0.0
  Downloading marshmallow-1.0.0-py2.py3-none-any.whl.metadata (15 kB)
Downloading marshmallow-1.0.0-py2.py3-none-any.whl (45 kB)
Would install marshmallow-1.0.0


$ pip install --dry-run protobuf==4.21.0rc1
  DEPRECATION: Wheel filename 'protobuf-4.21.0_rc_1-cp310-abi3-win_amd64.whl' uses an invalid filename format, as the version part '4.21.0_rc_1' is not correctly normalised, and contains an underscore character. Future versions of pip may fail to recognise this wheel. pip 25.1 will enforce this behaviour change. A possible replacement is rename the wheel to use a correctly normalised version part (this may require updating the version in the project metadata). Discussion can be found at https://github.com/pypa/pip/issues/12914
  DEPRECATION: Wheel filename 'protobuf-4.21.0_rc_1-cp37-abi3-macosx_10_9_universal2.whl' uses an invalid filename format, as the version part '4.21.0_rc_1' is not correctly normalised, and contains an underscore character. Future versions of pip may fail to recognise this wheel. pip 25.1 will enforce this behaviour change. A possible replacement is rename the wheel to use a correctly normalised version part (this may require updating the version in the project metadata). Discussion can be found at https://github.com/pypa/pip/issues/12914
  DEPRECATION: Wheel filename 'protobuf-4.21.0_rc_1-cp37-abi3-manylinux2014_aarch64.whl' uses an invalid filename format, as the version part '4.21.0_rc_1' is not correctly normalised, and contains an underscore character. Future versions of pip may fail to recognise this wheel. pip 25.1 will enforce this behaviour change. A possible replacement is rename the wheel to use a correctly normalised version part (this may require updating the version in the project metadata). Discussion can be found at https://github.com/pypa/pip/issues/12914
  DEPRECATION: Wheel filename 'protobuf-4.21.0_rc_1-cp37-abi3-manylinux2014_x86_64.whl' uses an invalid filename format, as the version part '4.21.0_rc_1' is not correctly normalised, and contains an underscore character. Future versions of pip may fail to recognise this wheel. pip 25.1 will enforce this behaviour change. A possible replacement is rename the wheel to use a correctly normalised version part (this may require updating the version in the project metadata). Discussion can be found at https://github.com/pypa/pip/issues/12914
  DEPRECATION: Wheel filename 'protobuf-4.21.0_rc_1-cp37-cp37m-win_amd64.whl' uses an invalid filename format, as the version part '4.21.0_rc_1' is not correctly normalised, and contains an underscore character. Future versions of pip may fail to recognise this wheel. pip 25.1 will enforce this behaviour change. A possible replacement is rename the wheel to use a correctly normalised version part (this may require updating the version in the project metadata). Discussion can be found at https://github.com/pypa/pip/issues/12914
  DEPRECATION: Wheel filename 'protobuf-4.21.0_rc_1-cp38-cp38-win_amd64.whl' uses an invalid filename format, as the version part '4.21.0_rc_1' is not correctly normalised, and contains an underscore character. Future versions of pip may fail to recognise this wheel. pip 25.1 will enforce this behaviour change. A possible replacement is rename the wheel to use a correctly normalised version part (this may require updating the version in the project metadata). Discussion can be found at https://github.com/pypa/pip/issues/12914
  DEPRECATION: Wheel filename 'protobuf-4.21.0_rc_1-cp39-cp39-win_amd64.whl' uses an invalid filename format, as the version part '4.21.0_rc_1' is not correctly normalised, and contains an underscore character. Future versions of pip may fail to recognise this wheel. pip 25.1 will enforce this behaviour change. A possible replacement is rename the wheel to use a correctly normalised version part (this may require updating the version in the project metadata). Discussion can be found at https://github.com/pypa/pip/issues/12914
  DEPRECATION: Wheel filename 'protobuf-4.21.0_rc_1-py3-none-any.whl' uses an invalid filename format, as the version part '4.21.0_rc_1' is not correctly normalised, and contains an underscore character. Future versions of pip may fail to recognise this wheel. pip 25.1 will enforce this behaviour change. A possible replacement is rename the wheel to use a correctly normalised version part (this may require updating the version in the project metadata). Discussion can be found at https://github.com/pypa/pip/issues/12914
  DEPRECATION: Wheel filename 'protobuf-4.21.0_rc_2-cp310-abi3-win32.whl' uses an invalid filename format, as the version part '4.21.0_rc_2' is not correctly normalised, and contains an underscore character. Future versions of pip may fail to recognise this wheel. pip 25.1 will enforce this behaviour change. A possible replacement is rename the wheel to use a correctly normalised version part (this may require updating the version in the project metadata). Discussion can be found at https://github.com/pypa/pip/issues/12914
  DEPRECATION: Wheel filename 'protobuf-4.21.0_rc_2-cp310-abi3-win_amd64.whl' uses an invalid filename format, as the version part '4.21.0_rc_2' is not correctly normalised, and contains an underscore character. Future versions of pip may fail to recognise this wheel. pip 25.1 will enforce this behaviour change. A possible replacement is rename the wheel to use a correctly normalised version part (this may require updating the version in the project metadata). Discussion can be found at https://github.com/pypa/pip/issues/12914
  DEPRECATION: Wheel filename 'protobuf-4.21.0_rc_2-cp37-abi3-macosx_10_9_universal2.whl' uses an invalid filename format, as the version part '4.21.0_rc_2' is not correctly normalised, and contains an underscore character. Future versions of pip may fail to recognise this wheel. pip 25.1 will enforce this behaviour change. A possible replacement is rename the wheel to use a correctly normalised version part (this may require updating the version in the project metadata). Discussion can be found at https://github.com/pypa/pip/issues/12914
  DEPRECATION: Wheel filename 'protobuf-4.21.0_rc_2-cp37-abi3-manylinux2014_aarch64.whl' uses an invalid filename format, as the version part '4.21.0_rc_2' is not correctly normalised, and contains an underscore character. Future versions of pip may fail to recognise this wheel. pip 25.1 will enforce this behaviour change. A possible replacement is rename the wheel to use a correctly normalised version part (this may require updating the version in the project metadata). Discussion can be found at https://github.com/pypa/pip/issues/12914
  DEPRECATION: Wheel filename 'protobuf-4.21.0_rc_2-cp37-abi3-manylinux2014_x86_64.whl' uses an invalid filename format, as the version part '4.21.0_rc_2' is not correctly normalised, and contains an underscore character. Future versions of pip may fail to recognise this wheel. pip 25.1 will enforce this behaviour change. A possible replacement is rename the wheel to use a correctly normalised version part (this may require updating the version in the project metadata). Discussion can be found at https://github.com/pypa/pip/issues/12914
  DEPRECATION: Wheel filename 'protobuf-4.21.0_rc_2-cp37-cp37m-win32.whl' uses an invalid filename format, as the version part '4.21.0_rc_2' is not correctly normalised, and contains an underscore character. Future versions of pip may fail to recognise this wheel. pip 25.1 will enforce this behaviour change. A possible replacement is rename the wheel to use a correctly normalised version part (this may require updating the version in the project metadata). Discussion can be found at https://github.com/pypa/pip/issues/12914
  DEPRECATION: Wheel filename 'protobuf-4.21.0_rc_2-cp37-cp37m-win_amd64.whl' uses an invalid filename format, as the version part '4.21.0_rc_2' is not correctly normalised, and contains an underscore character. Future versions of pip may fail to recognise this wheel. pip 25.1 will enforce this behaviour change. A possible replacement is rename the wheel to use a correctly normalised version part (this may require updating the version in the project metadata). Discussion can be found at https://github.com/pypa/pip/issues/12914
  DEPRECATION: Wheel filename 'protobuf-4.21.0_rc_2-cp38-cp38-win32.whl' uses an invalid filename format, as the version part '4.21.0_rc_2' is not correctly normalised, and contains an underscore character. Future versions of pip may fail to recognise this wheel. pip 25.1 will enforce this behaviour change. A possible replacement is rename the wheel to use a correctly normalised version part (this may require updating the version in the project metadata). Discussion can be found at https://github.com/pypa/pip/issues/12914
  DEPRECATION: Wheel filename 'protobuf-4.21.0_rc_2-cp38-cp38-win_amd64.whl' uses an invalid filename format, as the version part '4.21.0_rc_2' is not correctly normalised, and contains an underscore character. Future versions of pip may fail to recognise this wheel. pip 25.1 will enforce this behaviour change. A possible replacement is rename the wheel to use a correctly normalised version part (this may require updating the version in the project metadata). Discussion can be found at https://github.com/pypa/pip/issues/12914
  DEPRECATION: Wheel filename 'protobuf-4.21.0_rc_2-cp39-cp39-win32.whl' uses an invalid filename format, as the version part '4.21.0_rc_2' is not correctly normalised, and contains an underscore character. Future versions of pip may fail to recognise this wheel. pip 25.1 will enforce this behaviour change. A possible replacement is rename the wheel to use a correctly normalised version part (this may require updating the version in the project metadata). Discussion can be found at https://github.com/pypa/pip/issues/12914
  DEPRECATION: Wheel filename 'protobuf-4.21.0_rc_2-cp39-cp39-win_amd64.whl' uses an invalid filename format, as the version part '4.21.0_rc_2' is not correctly normalised, and contains an underscore character. Future versions of pip may fail to recognise this wheel. pip 25.1 will enforce this behaviour change. A possible replacement is rename the wheel to use a correctly normalised version part (this may require updating the version in the project metadata). Discussion can be found at https://github.com/pypa/pip/issues/12914
  DEPRECATION: Wheel filename 'protobuf-4.21.0_rc_2-py3-none-any.whl' uses an invalid filename format, as the version part '4.21.0_rc_2' is not correctly normalised, and contains an underscore character. Future versions of pip may fail to recognise this wheel. pip 25.1 will enforce this behaviour change. A possible replacement is rename the wheel to use a correctly normalised version part (this may require updating the version in the project metadata). Discussion can be found at https://github.com/pypa/pip/issues/12914
Collecting protobuf==4.21.0rc1
  Downloading protobuf-4.21.0_rc_1-cp37-abi3-manylinux2014_x86_64.whl.metadata (67 bytes)
Downloading protobuf-4.21.0_rc_1-cp37-abi3-manylinux2014_x86_64.whl (407 kB)
Would install protobuf-4.21.0-rc-1

These examples no longer fire the deprecation notice with this PR.

@notatallshaw notatallshaw force-pushed the update-non-PEP-440-wheel-filename-deprecation-notice branch from 686293f to fbe7924 Compare August 25, 2024 19:10
@notatallshaw notatallshaw added this to the 24.3 milestone Aug 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant