Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add vendored and test import groups to import sorting #12974

Merged
merged 4 commits into from
Oct 13, 2024

Conversation

notatallshaw
Copy link
Member

I've always found import groups a little weird in the test directory, because vendored libraries are mixed with third party libraries, and test imports are mixed with pip internal imports.

This change explicitly defines all the import groups, adding two new groups, "vendored" and "tests", because these are otherwise in the same order as the implicit import groups but with two new ones it just adds additional spaces to those groups.

@notatallshaw notatallshaw changed the title Vendored and test import groups Add vendored and test import groups to import sorting Sep 22, 2024
Copy link
Member

@ichard26 ichard26 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks a bit weird, but most of our test files aren't this tiny :)

@sbidoul sbidoul merged commit b0ebea9 into pypa:main Oct 13, 2024
34 checks passed
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 29, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants