Simplify, fix, and add unit tests for PipProvider.get_preference
#12982
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #12975
This PR does the following:
direct
as a preference based on this reasoning:direct
preference in resolution doesn't work #12975 (comment)get_preference
(removes logic flow via exception)get_preference
get_preference
Side note: I think I've found a bug in the way
parent_depths
is calculated when a requirement with an extra is involved, but it was too involved to fix in this PR, once I've pinned it down I will make a follow up PR.