Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Restore test isolation by allowing username override for PyPI #1131

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Restore test isolation by allowing username override for PyPI #1131

wants to merge 4 commits into from

Conversation

jaraco
Copy link
Member

@jaraco jaraco commented Jun 26, 2024 •
edited
Loading

Closes #1121

  • Extract method for 'is_pypi' to consolidate repeated behavior and documentation.
  • Default username to 'token' if not specified.
  • Restore ability for users to override the username even for PyPI.

@jaraco jaraco force-pushed the bugfix/1121-test-isolation branch from 1955602 to 3f90d88 Compare June 26, 2024 19:58
@jaraco
Copy link
Member Author

jaraco commented Sep 6, 2024

I'm working on twine again and this issue is once again affecting me and still attempting to leak my secrets.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@woodruffw woodruffw Awaiting requested review from woodruffw

@sigmavirus24 sigmavirus24 Awaiting requested review from sigmavirus24

@bhrutledge bhrutledge Awaiting requested review from bhrutledge

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Running twine tests in dev environment fail and emit PyPI tokens
1 participant
@jaraco