Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Flake8 lint error from irrelevant scripts occurred on some pull requests #956

Closed
quinn-sasha opened this issue Sep 22, 2024 · 2 comments · Fixed by #974
Closed

Flake8 lint error from irrelevant scripts occurred on some pull requests #956

quinn-sasha opened this issue Sep 22, 2024 · 2 comments · Fixed by #974
Assignees
Labels
bug Something isn't working

Comments

@quinn-sasha
Copy link

Describe the bug

Flake 8 lint warning from pdf_watermarkadder and video_cropper.

  • pdf_watermarkadder: missing whitespace after ',' on line 26 of main.py.
  • video_cropper: Didn't use isinstance() for checking if an object is an instance of a class or type

To Reproduce
Steps to reproduce the behavior:

  1. Create virtual environment and activate it
  2. pip install flake8
  3. Go to pdf_watermarkadder (or video_cropper) folder
  4. flake8 main.py (if you are in video_cropper, flake8 video_cropper.py)
  5. See error

Expected behavior

My pull request should pass flake8 lint check.

Screenshots
If applicable, add screenshots to help explain your problem.

image

Additional context

@quinn-sasha quinn-sasha added the bug Something isn't working label Sep 22, 2024
@Davda-James
Copy link
Contributor

Yes this is true today I have made a PR adding another script and there is no error in my script in linting but due to already existing scripts linting issue the linker check is failed.

@pawangeek
Copy link
Contributor

@Davda-James @quinn-sasha It's solved now, either make a dummy commit or fresh PR to run this, closed by #974

@pawangeek pawangeek linked a pull request Oct 10, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants