solved the linting issue in pdf_watermarkadder/main.py folder that is causing the flake8 linker checks to fail for other PR also #964
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is solving other error in other folders but still there is one error which is shown in the ./watermark_maker/main.py but locally I have tested that and there is no such error flake8 is not giving any error on linting, I guess that issue is caused due to the version difference. |
|
@Davda-James It's solved now by upgrading the python version + actions, by #974 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes what ?
Due to some linting error in pdf_watermarkadder/main.py file causing the flake8 linker check to fail in when anyone is making a PR on new scripts even though they have no errors in their own script.
Issue no.(must) -#956
I am open to suggestions if any and if not then please merge it as it would not cause the error for other who are adding new scripts and please add "hacktoberfest-accepted" label to it. Thank You