Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Meta: Add .git-blame-ignore-revs #3431

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

AA-Turner
Copy link
Member

@AA-Turner AA-Turner commented Sep 9, 2023

This adds a .git-blame-ignore-revs file to ignore (almost) every 'administrative' change in the PEPs repo, leaving users of git blame seeing the main meat of the commit history.

The types of ignores are:

  • reStructuredText conversion (but only pure conversion, for example dde379d, 631ff7f, e2a9d17, 2679eb0, etc aren't included)
  • Header normalisation or validation
  • Syntax fixes
  • typos/grammar
  • Whitespace changes
  • Mass changes, e.g. using :pep: or adding Topic headers

A


📚 Documentation preview 📚: https://pep-previews--3431.org.readthedocs.build/

Copy link
Member

@JelleZijlstra JelleZijlstra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is too much. We should ignore only those commits that changed whole files but weren't meaningful in terms of content, like the reST conversion.

# 2022-10-06: Fix reStructuredText syntax
7fa80c34d7b748600eb0d7421430f5af87dc42db

# 2022-10-06: Add ``Topic: Typing``
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This just adds these Topic lines, I don't see why this needs to be ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants