-
Notifications
You must be signed in to change notification settings - Fork 603
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(frontend): update sass compiler/toolchain #1709
base: main
Are you sure you want to change the base?
Conversation
5e6c85f
to
11b3692
Compare
…ass -I static/vendor/compass -I static/vendor/susy static/sass`
@berinhard this is ready for review. I think the main concern is making sure that the dev workflow (install, compile, watch, ci) makes sense and feels usable! Otherwise a general review of the resulting CSS is probably good. We might also consider dealing with the Deprecations/Warnings that |
@ewdurbin I've reviewed the PR and I was able to run everything with success after a minor fix in the
|
I'll start to work on each one of then today so we can merge and deploy this PR, ok? |
Absolutely! |
@ewdurbin I spent some time on this, but I guess my CSS/Sass skills aren't enough for this task. I'll share my discoveries on each topic:
This probably has to do with the usage of
For some reason, the And in production:
A similar thing like the sidebar classes is happening with every image defined via CSS. The
I couldn't figure this out yet, but it's a slight difference. |
Unsure! It would be nice to actually be able to compile sass in an automated way, but now many more years on there may be another way! |
This updates us to the latest dart based implementation of sass,
runserver
,sass
, andsass-watch
targets.Notes:
Used dart implementation of Sass from https://github.com/sass/dart-sass/releases/tag/1.30.0