Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rewritten Engine's terminate and terminate_epoch logic #2645

Merged
merged 13 commits into from
Aug 23, 2022
Merged

Rewritten Engine's terminate and terminate_epoch logic #2645

merged 13 commits into from
Aug 23, 2022

Conversation

vfdev-5
Copy link
Collaborator

@vfdev-5 vfdev-5 commented Aug 15, 2022 •
edited
Loading

Description:

  • terminate() work on all events, called on catched _EngineTerminateException
  • terminate_epoch() work on iteration-based events, called on catched _EngineTerminateSingleEpochExpection
  • Fixed issue when attaching handlers on Events.TERMINATE_SINGLE_EPOCH
  • Added tests

Check list:

  • New tests are added (if a new feature is added)
  • New doc strings: description and/or example code are in RST format
  • Documentation is updated (if required)

@sadra-barikbin can you please review and comment out what do you think ?

@vfdev-5
Added test_engine_run_resume
46cddf8
@vfdev-5
Terminate/Terminate Single Epoch work on all EPOCH/ITERATION events
f027a12
@vfdev-5
- terminate() work on all events, called on catched _EngineTerminateE…
8c36bfa 
…xception

- terminate_epoch work on iteration-based events, called on catched  _EngineTerminateSingleEpochExpection
- Fixed issue when attaching handlers on Events.TERMINATE_SINGLE_EPOCH
@github-actions github-actions bot added the module: engine Engine module label Aug 15, 2022
@vfdev-5
Copy link
Collaborator Author

vfdev-5 commented Aug 18, 2022

@sadra-barikbin do you have any other remarks for this PR that could be blocking it for being merged ?

@sadra-barikbin
Copy link
Collaborator

@sadra-barikbin do you have any other remarks for this PR that could be blocking it for being merged ?

I finalize my review in a few minutes.

@vfdev-5
Copy link
Collaborator Author

vfdev-5 commented Aug 18, 2022

I finalize my review in a few minutes.

@sadra-barikbin have you submitted your review ?

sadra-barikbin
sadra-barikbin reviewed Aug 18, 2022
View reviewed changes
ignite/engine/engine.py Show resolved Hide resolved
tests/ignite/engine/test_engine.py Outdated Show resolved Hide resolved
tests/ignite/engine/test_engine.py Show resolved Hide resolved
@vfdev-5 vfdev-5 force-pushed the rewrite-engine-terminate-and-co branch from 20ee6a9 to d350ff5 Compare August 22, 2022 20:50
@vfdev-5
Copy link
Collaborator Author

vfdev-5 commented Aug 22, 2022

@sadra-barikbin I updated the docs and tests etc. Please review it again. I want to merge it by tomorrow. Thanks

sadra-barikbin
sadra-barikbin reviewed Aug 23, 2022
View reviewed changes
ignite/engine/engine.py Show resolved Hide resolved
tests/ignite/engine/test_engine.py Show resolved Hide resolved
tests/ignite/engine/test_engine.py Show resolved Hide resolved
tests/ignite/engine/test_engine.py Show resolved Hide resolved
@vfdev-5 vfdev-5 merged commit 32ba9cd into pytorch:master Aug 23, 2022
@vfdev-5 vfdev-5 deleted the rewrite-engine-terminate-and-co branch August 23, 2022 14:24
@vfdev-5 vfdev-5 mentioned this pull request Aug 23, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sadra-barikbin sadra-barikbin sadra-barikbin approved these changes

Assignees
No one assigned
Labels
module: engine Engine module
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vfdev-5 @sadra-barikbin