make rdzv_backend configurable #739
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
kiukchung
approved these changes
Jul 21, 2023
There was a problem hiding this comment.
Thanks for the PR, LGTM.
Two small notes:
- Certain
rdzv_backendsrequire additional rendezvous configs to be passed asrdzv_conf KEY=VAL,KEY=VAL,..., so you might end up having to exposerdzv_confas well. - The
spmdcomponent (in the same file) callsddpand has a much cleaner argument list. So depending on what you are after, you might want to switch over tospmdand plumbrdzvargument through to that component as well.
Both are non-blocking comments. Approving.
|
@kiukchung thanks for the review. And happy to add those noted changes in an additional PR. After the approval, is there anything else I need to do before the PR can be mereged? |
|
Code looks good -- there's some CI failures in trunk which are unrelated to this (pyyaml regression + disk space issue on the underlying runners) |
KPostOffice
pushed a commit
to KPostOffice/torchx
that referenced
this pull request
Sep 7, 2023
MichaelClifford
added a commit
to project-codeflare/torchx
that referenced
this pull request
Sep 8, 2023
KPostOffice
pushed a commit
to KPostOffice/torchx
that referenced
this pull request
Feb 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary:
This PR allows the user to configure the
rdzv_backendthey want to use withddpand sets the default to "c10d". This also removes the previously hard-coded c10d rdzv_backend.Test plan:
This has been tested locally against
dist_test.pywith all 10 tests passing.